From 32c1ff97fbe69a4d030e0bc05b156a3733da396c Mon Sep 17 00:00:00 2001
From: Andrej Karpathy <andrej.karpathy@gmail.com>
Date: Mon, 14 Aug 2023 14:52:07 +0000
Subject: [PATCH] missed p->dim to kv_dim for k,v vectors. we're not doing
 anything wrong we're just being wasteful with memory. thanks @xefoci7612 for
 pointing out

---
 run.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/run.c b/run.c
index df95e6f..56ceff5 100644
--- a/run.c
+++ b/run.c
@@ -89,8 +89,8 @@ void malloc_run_state(RunState* s, Config* p) {
     s->hb = calloc(p->hidden_dim, sizeof(float));
     s->hb2 = calloc(p->hidden_dim, sizeof(float));
     s->q = calloc(p->dim, sizeof(float));
-    s->k = calloc(p->dim, sizeof(float));
-    s->v = calloc(p->dim, sizeof(float));
+    s->k = calloc(kv_dim, sizeof(float));
+    s->v = calloc(kv_dim, sizeof(float));
     s->att = calloc(p->n_heads * p->seq_len, sizeof(float));
     s->logits = calloc(p->vocab_size, sizeof(float));
     s->probindex = calloc(p->vocab_size, sizeof(ProbIndex));